Skip to content

Conversation

nishantagrawal01
Copy link

@nishantagrawal01 nishantagrawal01 commented Oct 30, 2021

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

Solution code for problem to find majority element in a given integer array

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@raklaptudirm
Copy link
Member

Please read the CONTRIBUTION.md before creating pull requests. We have strict guidelines on how to name files. Your file is not even a .js file.

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename files according to guidelines.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature Reviewed labels Oct 31, 2021
@raklaptudirm raklaptudirm added the abandoned This pull request has been abandoned label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This pull request has been abandoned algorithm Adds or improves an algorithm changes required This pull request needs changes feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants