Skip to content

Conversation

awojobigodfrey
Copy link

@awojobigodfrey awojobigodfrey commented Apr 18, 2022

Added a clear function for cache

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Added a clear function for cache
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please - at the very least - fix your indentation. Why is this feature necessary? Why can't I just call obj.cache.clear()?

Fixed indentation
@raklaptudirm
Copy link
Member

obj.clear() is less clear then obj.cache.clear() imo.

@@ -83,6 +83,11 @@ class LRUCache {
this.cache.set(key, value)
}

clear () {
this.cache.clear()
return this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why returns "this"?

@raklaptudirm
Copy link
Member

@appgurueu should I close this? We both seem to think it is unnecessary and less readable.

@appgurueu appgurueu added the wontfix Will not be fixed or is a feature label Apr 20, 2022
@appgurueu appgurueu closed this Apr 20, 2022
@awojobigodfrey awojobigodfrey deleted the patch-1 branch April 23, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix Will not be fixed or is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants