Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's lose the images and greedy_method directories #3956

Closed
cclauss opened this issue Nov 25, 2020 · 0 comments · Fixed by #3972
Closed

Let's lose the images and greedy_method directories #3956

cclauss opened this issue Nov 25, 2020 · 0 comments · Fixed by #3972
Assignees
@dhruvmanila
Labels
good first issue help wanted

Comments

@cclauss
Copy link
Member

cclauss commented Nov 25, 2020

As discussed at #3934 (comment)

There's also greedy_knapsack in the greedy_method directory.

Proposal:

  • Remove images and greedy_method directory.
  • Move greedy_knapsack to knapsack directory as there are multiple variations for the knapsack problem according to Wikipedia and multiple ways of solving as well.
@cclauss cclauss changed the title Let's lose the greedy_method directory Let's lose the images and greedy_method directories Nov 25, 2020
@cclauss cclauss mentioned this issue Nov 26, 2020
Closed
14 tasks
@dhruvmanila dhruvmanila mentioned this issue Nov 27, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes: #3956 Cleaned up knapsack and images directory dhruvmanila/Python
2 participants
@cclauss @dhruvmanila