Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctests, type hints; fix bug for dynamic_programming/minimum_partition.py #10012

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Add doctests, type hints; fix bug for dynamic_programming/minimum_partition.py #10012

merged 2 commits into from
Oct 8, 2023

Conversation

hollowcrust
Copy link
Contributor

@hollowcrust hollowcrust commented Oct 7, 2023 •
edited

Describe your change:

Fixes #9943.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 7, 2023
This was referenced Oct 8, 2023
Closed
Closed
@hollowcrust hollowcrust mentioned this pull request Oct 8, 2023
Closed
14 tasks
cclauss
cclauss approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever. I find these dynamic programming algorithms difficult to understand and they waste a lot of ram and processing power but thanks for adding tests.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023
@cclauss cclauss merged commit fa077e6 into TheAlgorithms:master Oct 8, 2023
3 checks passed
tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request Oct 8, 2023
@hollowcrust @pre-commit-ci @tianyizheng02
Add doctests, type hints; fix bug for dynamic_programming/minimum_par…
cdd54cb 
…tition.py (TheAlgorithms#10012)

* Add doctests, type hints; fix bug

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@hollowcrust hollowcrust deleted the adding_doctest branch October 11, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve our test coverage
2 participants
@hollowcrust @cclauss