Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD]: Improved tests in power recursion! #10664

Merged
merged 12 commits into from
Oct 20, 2023
Merged

[ADD]: Improved tests in power recursion! #10664

merged 12 commits into from
Oct 20, 2023

Conversation

imSanko
Copy link
Contributor

@imSanko imSanko commented Oct 18, 2023 •
edited

Describe your change:

[ADD]: New test cases for all_combinations !

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Add test cases

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new Python files are placed inside an existing directory.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Improve our test coverage #9943".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 18, 2023
@imSanko imSanko changed the title [ADD]: Inproved Tests [ADD]: Improved tests in power recursion! Oct 19, 2023
@imSanko
Copy link
Contributor Author

imSanko commented Oct 19, 2023 •
edited

@tianyizheng02 can you have a look

@imSanko imSanko closed this Oct 19, 2023
@imSanko imSanko reopened this Oct 19, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 19, 2023
@cclauss cclauss self-assigned this Oct 19, 2023
cclauss
cclauss requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests should either add/improve tests or should change the code. This PR changes both the tests and the code. This makes the PR much more difficult to review.

Please revert the change to the algorithm and the change of the filename. Let's have this pull request JUST focus on improving the testing.

@tianyizheng02 Perhaps we need to talk more in CONTRIBUTING.md about not changing both code and tests in a single PR.

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed awaiting changes A maintainer has requested changes to this PR labels Oct 19, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 19, 2023
@imSanko imSanko requested a review from cclauss October 19, 2023 09:30
@imSanko
Copy link
Contributor Author

imSanko commented Oct 20, 2023

@cclauss can you check the change, cause I've made the as per your choice.

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 20, 2023
@cclauss cclauss merged commit 4154428 into TheAlgorithms:master Oct 20, 2023
3 checks passed
@imSanko
Copy link
Contributor Author

imSanko commented Oct 20, 2023

@cclauss can you please add #hacktoberfest-accepted label.

@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

@cclauss cclauss

Labels
enhancement This PR modified some existing files hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve our test coverage
2 participants
@imSanko @cclauss