Skip to content

Create flash sort #11132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Create flash sort #11132

wants to merge 11 commits into from

Conversation

cemmanuelsr
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 31, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 31, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 31, 2023
@algorithms-keeper algorithms-keeper bot removed the require type hints https://docs.python.org/3/library/typing.html label Oct 31, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 31, 2023
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 31, 2023
@cclauss cclauss added ON HOLD: Final hours of Hacktoberfest We will review this PR after Hacktoberfest has ended and removed ON HOLD: Final hours of Hacktoberfest We will review this PR after Hacktoberfest has ended labels Oct 31, 2023
@cclauss
Copy link
Member

cclauss commented Nov 5, 2023

mypy.....................................................................Failed

  • hook id: mypy
  • exit code: 1
sorts/flash_sort.py:58: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:59: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:76: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:78: error: Argument 1 to "swap_index" has incompatible type "float"; expected "int"  [arg-type]
sorts/flash_sort.py:79: error: Unsupported target for indexed assignment ("Iterable[Any]")  [index]
sorts/flash_sort.py:79: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:80: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:96: error: Argument 1 to "len" has incompatible type "Iterable[Any]"; expected "Sized"  [arg-type]
sorts/flash_sort.py:97: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:100: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:101: error: Unsupported target for indexed assignment ("Iterable[Any]")  [index]
sorts/flash_sort.py:101: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:104: error: Unsupported target for indexed assignment ("Iterable[Any]")  [index]
sorts/flash_sort.py:123: error: Argument 1 to "len" has incompatible type "Iterable[Any]"; expected "Sized"  [arg-type]
sorts/flash_sort.py:127: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:129: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:130: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:131: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:132: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:135: error: Return value expected  [return-value]
sorts/flash_sort.py:140: error: No overload variant of "__getitem__" of "list" matches argument type "float"  [call-overload]
sorts/flash_sort.py:140: note: Possible overload variants:
sorts/flash_sort.py:140: note:     def __getitem__(self, SupportsIndex, /) -> int
sorts/flash_sort.py:140: note:     def __getitem__(self, slice, /) -> list[int]
sorts/flash_sort.py:140: error: No overload variant of "__setitem__" of "list" matches argument types "float", "Any"  [call-overload]
sorts/flash_sort.py:140: note:     def __setitem__(self, SupportsIndex, int, /) -> None
sorts/flash_sort.py:140: note:     def __setitem__(self, slice, Iterable[int], /) -> None
sorts/flash_sort.py:155: error: Unsupported target for indexed assignment ("Iterable[Any]")  [index]
sorts/flash_sort.py:155: error: Value of type "Iterable[Any]" is not indexable  [index]
sorts/flash_sort.py:157: error: Unsupported target for indexed assignment ("Iterable[Any]")  [index]
sorts/flash_sort.py:157: error: Value of type "Iterable[Any]" is not indexable  [index]
Found 26 errors in 1 file (checked 1288 source files)

@cemmanuelsr cemmanuelsr closed this by deleting the head repository Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants