Skip to content

Conversation

ShauryaDusht
Copy link

@ShauryaDusht ShauryaDusht commented Oct 12, 2024

In previous version there was no balancing of tree after deletion that should take balance factor in account. So, I updated the code using balance factor.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

ShauryaDusht and others added 2 commits October 12, 2024 19:05
In previous version of code balance factor was not taken in account
So, I updated the code using balance factor
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 12, 2024
@99991
Copy link

99991 commented Oct 12, 2024

Why two pull requests? #12009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants