Adding stooge sort #1206
Merged
Adding stooge sort #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing Travis CI builds are not caused by this PR but are instead caused by my mistake in #1205. |
cclauss
reviewed
Sep 26, 2019
|
While waiting, you should be able to test this locally with python3 -m doctest -v sorts/stooge_sort.py |
|
It is ready, could you do the review? |
cclauss
approved these changes
Sep 26, 2019
|
Thank you! |
|
On thing to think about in the future is the difference between list.sort() and sorted(list) in Python. The first is an in-place sort (like this stooge_sort()) while the second returns a new sorted list without modifying the original list. Both are useful but I tend to like the second better. |
|
Ok, thank you for your time. |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Adding stooge sort * Updated doctest * Just added underscore in the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.