Skip to content

Adding the function is_proth_number #12399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 7, 2025
Merged

Adding the function is_proth_number #12399

merged 22 commits into from
Sep 7, 2025
+50 −0

Conversation

Juanitoupipou
Copy link
Contributor

@Juanitoupipou Juanitoupipou commented Nov 27, 2024 •
edited by MaximSmolskiy
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 27, 2024
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 27, 2024
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 27, 2024
@Juanitoupipou Juanitoupipou reopened this Nov 27, 2024
@algorithms-keeper algorithms-keeper bot added the enhancement This PR modified some existing files label Nov 27, 2024
@MaximSmolskiy MaximSmolskiy changed the title Adding the function isProthNumber(n : int) which returns true if n is… Adding the function is_proth_number Sep 7, 2025
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass labels Sep 7, 2025
@algorithms-keeper algorithms-keeper bot removed tests are failing Do not merge until tests pass labels Sep 7, 2025
MaximSmolskiy
MaximSmolskiy approved these changes Sep 7, 2025
View reviewed changes
Copy link
Member

@MaximSmolskiy MaximSmolskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Juanitoupipou Just for your information, there was a bug in your implementation - infinite loop for number = 1 input

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 7, 2025
@MaximSmolskiy MaximSmolskiy merged commit 8f1a6b0 into TheAlgorithms:master Sep 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaximSmolskiy MaximSmolskiy MaximSmolskiy approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juanitoupipou @MaximSmolskiy