Skip to content

Update fibonacci_sequence_recursion.py #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update fibonacci_sequence_recursion.py #1268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab36ea4
Update fibonacci_sequence_recursion.py
NikhilCodes Oct 3, 2019
a5da494
Minimized the code a bit.
NikhilCodes Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions maths/fibonacci_sequence_recursion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
# Fibonacci Sequence Using Recursion

def recur_fibo(n):
if n <= 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this doctest:

def recur_fibo(n):
    """
    >>> [recur_fibo(i) for i in range(12)]
    [0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]
    """
    return n if n <= 1 else recur_fibo(n-1) + recur_fibo(n-2)

return n
else:
(recur_fibo(n-1) + recur_fibo(n-2))
return n if n <= 1 else recur_fibo(n-1) + recur_fibo(n-2)

def isPositiveInteger(limit):
Copy link
Member

@cclauss cclauss Oct 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isPositiveInteger() function is too simple to be useful. Please removed it and do the test inline.

return limit >= 0
Expand Down