introduced shuffled_shift_cipher.py in /ciphers #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
Oct 23, 2019
cclauss
reviewed
Oct 23, 2019
removed __make_one_digit()
cclauss
reviewed
Oct 23, 2019
|
Thanks for helping out with this commit. 👍 Any other changes needed for this PR or is everything set now? |
cclauss
approved these changes
Oct 23, 2019
|
This was our 1,000th PR closed. |
|
Loved the prompt response and reviews I got for my PRs for the last two days. 👍 This was one of my first useful contributions in the open-source community and the experience has left me wanting to contribute more and more. 😄 The 1,000th PR will be a milestone to remember for me. 🎉 🎉 |
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* introduced shuffled_shift_cipher.py in /ciphers * made requested changes * introduced doctests, type hints removed __make_one_digit() * test_end_to_end() inserted * Make test_end_to_end() a test ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a modified shift cipher algorithm with the explanation in the docstrings