Skip to content

Reduced Time Complexity to O(sqrt(n)) #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2022
Merged

Reduced Time Complexity to O(sqrt(n)) #7429

merged 3 commits into from
Oct 23, 2022

Conversation

Hannibal404
Copy link
Contributor

@Hannibal404 Hannibal404 commented Oct 19, 2022 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 19, 2022
@Hannibal404 Hannibal404 reopened this Oct 19, 2022
Abinashbunty
Abinashbunty suggested changes Oct 19, 2022
View reviewed changes
CaedenPH
CaedenPH reviewed Oct 19, 2022
View reviewed changes
@Hannibal404 Hannibal404 requested a review from CaedenPH October 20, 2022 16:08
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 23, 2022
@prateekiiest prateekiiest added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 23, 2022
@prateekiiest prateekiiest merged commit a3383ce into TheAlgorithms:master Oct 23, 2022
@Hannibal404 Hannibal404 deleted the patch-2 branch October 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekiiest prateekiiest prateekiiest approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

+1 more reviewer

@Abinashbunty Abinashbunty Abinashbunty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hannibal404 @prateekiiest @CaedenPH @Abinashbunty