Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions build: Add more tests #8837

Merged
merged 5 commits into from
Jun 25, 2023
Merged

GitHub Actions build: Add more tests #8837

merged 5 commits into from
Jun 25, 2023

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented Jun 25, 2023 •
edited

Re-enable some tests that were disabled in #6591.
Partial fix for #8818

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

cclauss and others added 2 commits June 25, 2023 09:35
@cclauss
GitHub Actions build: Add more tests
9228f73 
Re-enable some tests that were disabled in #6591.
Fixes #8818
updating DIRECTORY.md
c93aba0
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Jun 25, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Jun 25, 2023
@cclauss cclauss mentioned this pull request Jun 25, 2023
Open
@cclauss cclauss enabled auto-merge (squash) June 25, 2023 08:10
@cclauss cclauss merged commit 3bfa89d into master Jun 25, 2023
4 checks passed
@dhruvmanila dhruvmanila deleted the Re-enable-tests branch June 25, 2023 16:28
harshsingh32
harshsingh32 reviewed Sep 19, 2023
View reviewed changes
Copy link

@harshsingh32 harshsingh32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshsingh32 harshsingh32 harshsingh32 left review comments

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

@dhruvmanila dhruvmanila

Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cclauss @harshsingh32 @dhruvmanila