Skip to content

Conversation

ptrsxu
Copy link
Contributor

@ptrsxu ptrsxu commented Sep 21, 2022

The former Aho Corasick code fails on non-ascii utf8 strings. This pr fix the problem.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but please fix the build check

@ptrsxu
Copy link
Contributor Author

ptrsxu commented Sep 22, 2022

The code looks good, but please fix the build check

ok, updated.

@ptrsxu ptrsxu requested a review from siriak September 22, 2022 11:56
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) September 23, 2022 07:05
@siriak siriak merged commit 9f5bd84 into TheAlgorithms:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants