Implement the elliptic curve group law #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is done for a finite field of characteristic != 2, 3 and the curve of the form `y^2 = x^3 + Ax^2 + B`. Also include an implementation of a finite field of prime order P which is used in examples and tests.
|
I am considering to split this PR into two:
What do you think? |
The `Field` trait actually describes any field, not only a field representable by i64.
|
Feel free to split this into 2 PRs. And could you implement Field in a separate file? So that it can be reused for other algorithms |
|
Ping me when it's time to review |
The field trait will allow us to define an elliptic curve over any field. We provide an implementation of the trait for a prime field of order `P`, that is, the field isomorpic to the finite field `GF(P) = ℤ/Pℤ`. This field will be used to define specific elliptic curves.
|
Based on top of #549. Waiting for the latter to be reviewed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The implementation is done for a finite field of characteristic != 2, 3
and the curve of the form
y^2 = x^3 + Ax^2 + B.Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warningsjust before my last commit and fixed any issue that was found.cargo fmtjust before my last commit.cargo testjust before my last commit and all tests passed.COUNTRIBUTING.mdand my code follows its guidelines.