Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fix heap corruption in Floyd's algorithm tests
Problem
The test
test_detect_cycle_with_cycle
creates a cycle in a LinkedList but doesn't break it before the list is dropped. This causes heap corruption because the Drop implementation tries to free nodes in an infinite loop, potentially causing double-frees.Solution
Break the cycle at the end of the test by setting the tail's next pointer to None.
Testing
cargo test data_structures
multiple times without heap corruption errors--test-threads=1
for consistencyFixes intermittent test failures with "Heap corruption detected" errors.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.Note I ran cargo clippy --all -- -D warnings locally, and the build fails due to 24 existing warnings/errors (e.g., clippy::manual-is-multiple-of, clippy::needless-range-loop) in unrelated files (ciphers, math, sorting).
cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.