Skip to content

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Sep 30, 2025

Pull Request Template

Description

This PR removes if_not_else from the list of from the list of suppressed lints.

Continuation of #743.

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

@vil02 vil02 requested a review from siriak September 30, 2025 22:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 53.75000% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.32%. Comparing base (7d7d716) to head (b8b5a56).

Files with missing lines Patch % Lines
src/data_structures/rb_tree.rs 43.75% 36 Missing ⚠️
src/math/modular_exponential.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
- Coverage   95.33%   95.32%   -0.01%     
==========================================
  Files         319      319              
  Lines       20901    20899       -2     
==========================================
- Hits        19925    19923       -2     
  Misses        976      976              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02 vil02 marked this pull request as ready for review September 30, 2025 22:37
@vil02 vil02 requested a review from imp2002 as a code owner September 30, 2025 22:37
@vil02 vil02 force-pushed the include_if_not_else branch from 7b634dd to f0600cc Compare October 1, 2025 07:34
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit ed7a42e into TheAlgorithms:master Oct 1, 2025
6 checks passed
@vil02 vil02 deleted the include_if_not_else branch October 1, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants