Skip to content

Conversation

WayneKeenan
Copy link
Contributor

@WayneKeenan WayneKeenan commented Nov 5, 2017

Lighting the blue touch paper, on fireworks night!

A first pass at an implementation of the Observer role, Advertiser role and Eddystone Beacons.

More focus has been placed on the public facing API, internal module structure and testing/examples than has been placed on ensuring comprehensive functionality.

tl;dr hopefully easy to drive, hopefully not to messy under the hood, and just enough fuel to get by.

README.rst Outdated
adapter = get_provider().get_adapter()
beacon = EddystoneBeacon(adapter)
beacon.url = 'https://www.bluetooth.com/'
beacons.start()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beacon not beacons

README.rst Outdated
beacon = EddystoneBeacon(adapter)
beacon.url = 'https://www.bluetooth.com/'
beacons.start()
beacons.stop()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beacon not beacons

beacons.stop()
Example - Observer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not many adverts were turning up.
I tried getting my phone to advertise and that didn't turn up at all.
When I did beacons it would turn up twice and then no more showed up.

@WayneKeenan
Copy link
Contributor Author

My bad, those snippets in the read me are only meant to give a flavour, they are missing bits.

Because they are missing a 'sleep' between the start and stop you get pretty much nada.

Please run the scripts in 'examples' folder.

They should be removed or made fully functional. Probably removed as they aren't run as part of automated testing.

@WayneKeenan
Copy link
Contributor Author

I have updated the readme, please see commit c6f9f5b

@WayneKeenan WayneKeenan merged commit f5448b0 into master Nov 17, 2017
@WayneKeenan WayneKeenan deleted the wk_draft_experiment branch November 27, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants