Skip to content

Conversation

ShayNehmad
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@sandspider2234 sandspider2234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - check out the comments and change accordingly


This is a game server. Please try to not mess it up ¯\_(ツ)_/¯
If you find any issues, let me know @ShayNehmad on Twitter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some notes about the server config?
"Your shell is ZSH with oh-my-zsh etc."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be on the site. No need to see each login

Dockerfile Outdated
# TODO - change the gamemaster password?
# TODO - change the gamemaster username to git?
RUN useradd --comment "GameMaster account" --create-home --password $(mkpasswd -m sha-512 gamemaster) gamemaster
RUN useradd --comment "Player account" --create-home --password $(mkpasswd -m sha-512 player) --shell /bin/zsh player
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it /usr/bin/zsh?
Anyways, probably better to use $(which zsh)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Collaborator

@sandspider2234 sandspider2234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪

@ShayNehmad ShayNehmad merged commit 6a851fb into dev May 21, 2020
@ShayNehmad ShayNehmad deleted the docker branch May 21, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants