Feature/generate levels graph #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still missing some documentation and some UTs
sandspider2234
requested changes
May 28, 2020
| @@ -0,0 +1,163 @@ | |||
| use log::{debug, info}; | |||
| use petgraph::algo::is_cyclic_directed; | |||
There was a problem hiding this comment.
Or is it? My rustc shows that it's unused, but it's there in line 113. Weird.
There was a problem hiding this comment.
It's part of the tests - not compiled directly to the output binary. Moved the import into mod tests
sandspider2234
requested changes
May 28, 2020
levels/game-config.toml
Outdated
| branch = "master" | ||
| solution_checker = "echo No pushing to master. Read the README file; exit 1" | ||
| flags = [] # ["start-here"], but it's implicit in the readme | ||
| flags = ["start-here"] |
There was a problem hiding this comment.
A bit of trailing whitespace at the end :)
https://marketplace.visualstudio.com/items?itemName=shardulm94.trailing-spaces
sandspider2234
approved these changes
May 28, 2020
scripts/src/bin/templates/graph.tmpl
Outdated
| if (1 == params.nodes.length) \{ | ||
| levelName = data.nodes[params.nodes[0]].label; | ||
| console.log("Clicked on one node, it's this node: " + levelName); | ||
| document.location.href = "http://localhost:1313/levels/" + levelName; |
There was a problem hiding this comment.
There should be a script parameter for prod/test, switching the href assignment accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
The result looks like this: