Skip to content

Added service account IDs to mark as read #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Added service account IDs to mark as read #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/Services/GitHub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ protected function shouldSkip(NotificationData $notification, ItemData $item): b
return true;
}

if ($this->exceptMentions && $notification->reason === 'mention' && $this->isNotDependabot($item)) {
if ($this->exceptMentions && $notification->reason === 'mention' && $this->isNotServiceAccount($item)) {
return true;
}

Expand Down Expand Up @@ -223,8 +223,8 @@ protected function detected(int $count): void
Output::info("unread $pluralized detected", $count);
}

protected function isNotDependabot(ItemData $item): bool
protected function isNotServiceAccount(ItemData $item): bool
{
return $item->ownerId !== config('bots.dependabot');
return ! in_array($item->ownerId, config('bots.accounts'), true);
}
}
6 changes: 5 additions & 1 deletion config/bots.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<?php

return [
'dependabot' => 49699333,
'accounts' => [
9919, // GitHub
49699333, // dependabot
41898282, // GitHub Actions
],
];