Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating GreyNoise analyzer to use v2 API #562

Merged
merged 2 commits into from Dec 17, 2019

Conversation

@shortstack
Copy link
Contributor

shortstack commented Nov 15, 2019

No description provided.

shortstack added 2 commits Nov 15, 2019
@shortstack

This comment has been minimized.

Copy link
Contributor Author

shortstack commented Nov 16, 2019

need some guidance on the failed build. what do i need to do, if anything, on my end?

@3c7
3c7 approved these changes Nov 16, 2019
Copy link
Member

3c7 left a comment

Nothing wrong with your commit. The check seems to fail because of missing environment variables.

@3c7 3c7 changed the base branch from master to develop Nov 16, 2019
@shortstack

This comment has been minimized.

Copy link
Contributor Author

shortstack commented Dec 11, 2019

@3c7 any idea when this could get pulled in? i see the "approved", just curious. thank you!

@3c7

This comment has been minimized.

Copy link
Member

3c7 commented Dec 17, 2019

@shortstack Finally holidays, so I have some time to merge. :) Thanks for your contribution!

@3c7 3c7 changed the base branch from develop to release/2.4.0 Dec 17, 2019
@3c7 3c7 merged commit 6f97884 into TheHive-Project:release/2.4.0 Dec 17, 2019
1 check failed
1 check failed
continuous-integration/drone/pr Build is failing
Details
@3c7 3c7 added this to the 2.4.0 milestone Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.