02-class-id-selectors: Change solution #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Third and fourth elements share the same declaration for font-size.
Zekumoru
force-pushed
the
fix_exercise_solution
branch
from
574f345 to
4634b5f
Compare
dm-murphy
added
the
Status: Needs Review
| @@ -14,6 +14,5 @@ | |||
|
|
|||
| #four { | |||
There was a problem hiding this comment.
Since this is still relatively early and users may not have had a chance to gain an understanding of reducing code duplication, I think it would be worth adding a comment above the #four block along the lines of "Instead of applying the adjust-font-size class to this element in the HTML file, you could have also simply added a rule to the #four selector to set the font size. Reusing the class on this element helps reduce duplicate code."
There was a problem hiding this comment.
I agree as well because it isn't apparent that the class adjust-font-size is meant to reduce code duplication and new users will miss it out.
thatblindgeye
added
Status: Awaiting Response
thatblindgeye
approved these changes
Nov 19, 2022
Oussama5379
added a commit
to Oussama5379/css-exercises
that referenced
this pull request
Feb 1, 2025
…tion 02-class-id-selectors: Change solution
repo-jr
added a commit
to repo-jr/css-exercises
that referenced
this pull request
Aug 29, 2025
…tion 02-class-id-selectors: Change solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third and fourth elements share the same declaration of font-size.
Complete the following REQUIRED checkboxes:
location of change: brief description of changeformat, e.g.01-flex-center: Update self checkComplete the following checkbox ONLY IF it is applicable to your PR. You can complete it later if it is not currently applicable:
1. Because:
The third and fourth element share the same declaration for font-size of 24px and since the formerly class 'oddly-cool' already declared it, I removed the same declaration from the 'fourth' id and use the new renamed class 'adjust-font-size' of 'oddly-cool' to the fourth element instead. Also, this refreshes the idea that you can put id and class in the same element.
2. This PR:
3. Additional Information: