Add git hash #235
Add git hash #235
Conversation
CMakeLists.txt
Outdated
| include(FetchContent) | ||
|
|
||
| FetchContent_Declare(cmake_git_version_tracking | ||
| GIT_REPOSITORY https://github.com/andrew-hardin/cmake-git-version-tracking.git | ||
| GIT_TAG 904dbda1336ba4b9a1415a68d5f203f576b696bb | ||
| ) | ||
| FetchContent_MakeAvailable(cmake_git_version_tracking) | ||
|
|
There was a problem hiding this comment.
Can you try using a submodule instead? This is for consistency with how all other libraries are added. It can be put it in the 3rdparty directory, and added using add_subdirectory. the other dependencies work as examples.
There was a problem hiding this comment.
Something I'm curious/concerned about is how this library selects which git repository to read info from. Most likely, it won't select itself. It somehow has to obtain the parent that added it.
There was a problem hiding this comment.
Alright I'll do some testing and see how that works out
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "gitlens.currentLine.enabled": false | |||
| } | |||
There was a problem hiding this comment.
generally you should prefer having a trailing newline, to prevent tools like github from giving you angry red circles.
| @@ -64,6 +64,14 @@ | |||
| #include <string_view> | |||
| #include <thread> | |||
| #include <unordered_map> | |||
| #if __has_include("git.h") | |||
| #include "git.h" | |||
There was a problem hiding this comment.
Why wouldn't it have this header?
Fixes #85