[GEN][ZH] Prevent using uninitialized memory 'result' in PartitionData::calcMaxCoiForShape() #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a::calcMaxCoiForShape()
xezon
added
Minor
roossienb
requested changes
Jun 21, 2025
| @@ -2175,8 +2175,12 @@ Int PartitionData::calcMaxCoiForShape(GeometryType geom, Real majorRadius, Real | |||
| Real diagonal = (Real)(sqrtf(majorRadius*majorRadius + minorRadius*minorRadius)); | |||
| Int cells = ThePartitionManager->worldToCellDist(diagonal*2) + 1; | |||
| result = cells * cells; | |||
| break; | |||
There was a problem hiding this comment.
This break is already added in #1135.
There was a problem hiding this comment.
Yes. It will be removed one the second one to be merged.
| @@ -2168,8 +2168,12 @@ Int PartitionData::calcMaxCoiForShape(GeometryType geom, Real majorRadius, Real | |||
| Real diagonal = (Real)(sqrtf(majorRadius*majorRadius + minorRadius*minorRadius)); | |||
| Int cells = ThePartitionManager->worldToCellDist(diagonal*2) + 1; | |||
| result = cells * cells; | |||
| break; | |||
There was a problem hiding this comment.
This break is already added in #1135.
| }; | ||
| static_assert(GEOMETRY_NUM_TYPES == 3, "GEOMETRY_NUM_TYPES has changed"); |
There was a problem hiding this comment.
This static assert will trigger if the GEOMETRY_NUM_TYPES was changed and show that this switch case needs updating.
roossienb
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents using uninitialized memory 'result' in PartitionData::calcMaxCoiForShape() to make the compiler happy.
This is effectively just a refactor because this is impossible to happen because we expect passing valid enum values only. Handling default case is just courtesy.