Skip to content

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Aug 25, 2022

This converts the code to TypeScript. This allows using this library in the TypeScript code without errors.

@TheTechsTech
Copy link
Owner

I initially design this under Node v12 which it only tests on, most of your additions seem to require v18.
The CI file needs updating or some conditional version build instructions and/or maybe major version update change.

@TheTechsTech
Copy link
Owner

I have updated the CI build file, no issues revealed. The typescript related errors needs to be addressed in https://github.com/TheTechsTech/node-sys/actions/runs/2925392401

@aminya
Copy link
Contributor Author

aminya commented Aug 26, 2022

I had to rebase the branch for the changes to be effective

@TheTechsTech TheTechsTech merged commit f15e0de into TheTechsTech:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants