This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Add field/device specific subscribe, closes #9 and closes #8 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FokkeZB
changed the title
|
I simplified the code and API. Both |
johanstokking
suggested changes
Sep 21, 2016
| } | ||
| this.ee.emit(topic, devId, payload); // full topic, including field if any | ||
| this.ee.emit(parts.slice(0, 2).concat('+', parts.slice(3)).join('/'), devId, payload); // any device |
There was a problem hiding this comment.
Why do we want SDK users to work directly with our topic structure?
There was a problem hiding this comment.
They don't, as you can see in on() and off() we translate their arguments to the topic that we only internally use as the eventName so that the above 2 emitted events reach the right listeners. See the client test.
| client = new ttn.Client(BROKER); // don't pass appId and appAccessKey to the test broker | ||
| client.appId = Math.floor(Math.random() * 16777215).toString(16); // but set random appId afterwards | ||
| return client; | ||
| } |
There was a problem hiding this comment.
Convert tabs to spaces
| }); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Convert tabs to spaces
johanstokking
approved these changes
Sep 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9 and #8
This also introduces Mocha/Should tests that run before every commit.
For the new API of
on('message')andon('activation')see the client testAlso,> Re-added to not break #2 / #19dev_idandapp_idare no longer added to the payload since the callbacks now get these via arguments.