Skip to content

Asian frequency plans #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 16, 2017
Merged

Asian frequency plans #199

merged 8 commits into from
Jun 16, 2017

Conversation

jpmeijers
Copy link
Collaborator

Added the other higher Asian frequency plan, as well as the Korean frequency plan. Needs to be tested on a physical device before merging in.

@jpmeijers jpmeijers mentioned this pull request Apr 17, 2017
Closed
@jpmeijers jpmeijers force-pushed the asian-frequency-plans branch from b80ba31 to 5d643fe Compare April 17, 2017 22:01
@jpmeijers jpmeijers force-pushed the asian-frequency-plans branch from 5d643fe to ffbc988 Compare April 17, 2017 22:03
@johanstokking johanstokking requested a review from tftelkamp April 18, 2017 13:18
@johanstokking
Copy link
Member

Please resolve conflict

johanstokking
johanstokking approved these changes May 11, 2017
View reviewed changes
Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No FSK or wide band in KR?

@jpmeijers
Copy link
Collaborator Author

jpmeijers commented May 11, 2017 •
edited
Loading

Not according to the LoRaWAN Region Parameters doc. It implies that the channels and bandwidth is fixed by the regulator in Korea. We could however put a FSK channel on one of the current LoRa channels. But preferably we do not want LoRa on the same channel as FSK due to interference from LoRa to FSK. We can think about making a change like this at a later stage, and rather keep to the LoRaWAN standard for now.

@jpmeijers
Copy link
Collaborator Author

TTN_FP_AS920_923
Tested: Valid commands, ABP, OTAA, downlinks in RX1
Not tested: RX2 (not implemented in backend)

TTN_FP_AS923_925
Tested: Valid commands, ABP, OTAA, downlinks in RX1
Not tested: RX2 (not implemented in backend)

TTN_FP_KR920_923
Tested: Valid commands
Not tested: ABP, OTAA, downlinks - because TheThingsNetwork/gateway-conf#7

Fixed a few issues that arose during testing.

@jpmeijers
Enable saveState for RN2903AS.
4500ae7 
This problem was caused by not waiting for an ok after mac save.
Fixed by #211
@johanstokking johanstokking merged commit c63f0d0 into master Jun 16, 2017
@johanstokking johanstokking deleted the asian-frequency-plans branch June 16, 2017 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

@tftelkamp tftelkamp Awaiting requested review from tftelkamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmeijers @johanstokking