Skip to content

Conversation

htdvisser
Copy link
Contributor

Summary

This pull request lowers the minimum length of user IDs to 2, for better compatibility with v2 ID restrictions.

Closes #3723.

Testing

Should be covered by existing tests

Regressions

This may not (immediately) work with external integrations that work with user IDs and use the same validation rules as we did.

Notes for Reviewers

n/a

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@htdvisser htdvisser added the bump/minor Needs new minor version for release label May 6, 2021
@htdvisser htdvisser added this to the v3.13.0 milestone May 6, 2021
@htdvisser htdvisser self-assigned this May 6, 2021
@github-actions github-actions bot added compat/api This could affect API compatibility ui/web This is related to a web interface labels May 6, 2021
@htdvisser htdvisser force-pushed the issue/3723-short-user-ids branch from 4a7a71c to e5ba4e3 Compare May 6, 2021 13:17
@htdvisser htdvisser force-pushed the issue/3723-short-user-ids branch from e5ba4e3 to 425cb29 Compare May 7, 2021 07:11
@htdvisser htdvisser merged commit c26671e into v3.13 May 7, 2021
@htdvisser htdvisser deleted the issue/3723-short-user-ids branch May 7, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump/minor Needs new minor version for release compat/api This could affect API compatibility ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change ID regex to allow IDs with length of 2

3 participants