Adding Spin Jump Restart to Super Cas'Troid Mode #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivelin
approved these changes
Feb 9, 2022
|
I'm not sure what you did differently from me, but it seems to work as far as I can tell. I added a try/finally to ensure the streams are still disposed of when an exception occurs and some slight code style changes, but otherwise good work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I think the reason the ips was breaking before was because of the way SMZ3 splits up SM into two chunks. So, I apply the batch before that, and it seems to work. Made in a way we could possibly pull in other ips files for SM (if there are any).