fix: problem with scroll to bottom of the flatList when system keyboard is opened #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
approved these changes
Aug 7, 2023
ginsueddy
added a commit
to CommE2E/comm
that referenced
this pull request
Sep 7, 2023
Summary: Our friends from `rn-emoji-keyboard` just released a new update to their emoji keyboard library which includes a fix for the bug mentioned in [[ https://linear.app/comm/issue/ENG-4277/cant-scroll-to-bottom-of-mobile-emoji-search-when-keyboard-is-up-on | ENG-4277 ]]. This diff updates our usage of `rn-emoji-keyboard` to this latest version Link to PR: TheWidlarzGroup/rn-emoji-keyboard#149 Test Plan: Check out the demo video to see that keyboard is no longer blocking the bottom emojis when the keyboard is open {F743924} Reviewers: atul, ashoat, kamil Reviewed By: atul, ashoat Subscribers: ashoat, tomek Differential Revision: https://phab.comm.dev/D9087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the system keyboard opened there was not enough bottom padding in the FlatList. Some emojis were hidden by the keyboard.
Now:
https://github.com/TheWidlarzGroup/rn-emoji-keyboard/assets/37906388/88fe2834-0d5c-4ba8-ba3f-2531157ebb22
Previous:
https://github.com/TheWidlarzGroup/rn-emoji-keyboard/assets/37906388/b3b32c30-9426-4545-96e9-46cb4641ffa3