Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modeled the new comments markup after the default html5 comments template in core. #60
Before merging, I'd like feedback on one thing. /cc @emhr @scottnix
The comment author, permalink etc gets wrapped in a
<footer>
element with classcomment-meta
. I then changed the class of the formercomment-meta
div tocomment-metadata
, and the same for the corresponding output filter. I am inclined to also change the name of the function to match, but wonder if the name changing will be a source of confusion and/or breakage.Current comment markup:
The function outputting the
.comment-metadata
div is calledthematic_commentmeta()
. This is the one I'm considering renaming tothematic_commentmetadata()
, just for consistency. Or should we keep thecomment-meta
class on the div and give the footer element another class name?