Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments html5 #69

Merged
merged 6 commits into from
Mar 20, 2014
Merged

Comments html5 #69

merged 6 commits into from
Mar 20, 2014

Conversation

middlesister
Copy link
Member

I modeled the new comments markup after the default html5 comments template in core. #60

Before merging, I'd like feedback on one thing. /cc @emhr @scottnix

The comment author, permalink etc gets wrapped in a <footer> element with class comment-meta. I then changed the class of the former comment-meta div to comment-metadata, and the same for the corresponding output filter. I am inclined to also change the name of the function to match, but wonder if the name changing will be a source of confusion and/or breakage.

Current comment markup:

<li id="comment-{id}" >
    <article id="comment-body-{id}" class="comment-body">
        <footer class="comment-meta">
            <div class="comment-author vcard"> {thematic_commenter_link}</div><!-- .comment-author -->

            <div class="comment-metadata">';
                <time datetime="'. get_comment_time( 'c' ). '">{comment_posted_at}</time>';
                {comment permalink}
                {comment edit link}
            </div>

            {comment moderation notice}

        </footer><!-- .comment-meta -->

        <div class="comment-content">
            {comment_text}
        </div><!-- .comment-content -->
        {comment reply link}
    </article><!-- .comment-body -->

The function outputting the .comment-metadata div is called thematic_commentmeta(). This is the one I'm considering renaming to thematic_commentmetadata(), just for consistency. Or should we keep the comment-meta class on the div and give the footer element another class name?

Add filter for using xhtml callback in legacy mode
Add xhtml callback and childtheme override for xhtml mode
Add tests files for comments and legacy comments
Correcting a missing namespacing of filter
Fix name conflict with test class for standard comments
@middlesister middlesister mentioned this pull request Oct 12, 2013
8 tasks
Conflicts:
	library/legacy/legacy.php
Keep the .comment-meta classes and filters on the
output of thematic_commentmeta(). Do not change any filters
if at all possible
@middlesister
Copy link
Member Author

I kept the .comment-meta class name and gave the footer the css class .comment-utility. No reason to change existing classes and filters, and class naming is consistent with entry-utility of the posts.

middlesister added a commit that referenced this pull request Mar 20, 2014
@middlesister middlesister merged commit 324c951 into develop Mar 20, 2014
@middlesister middlesister deleted the comments-html5 branch March 20, 2014 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant