-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address CRAN comments #69
Comments
ArthurData
added a commit
that referenced
this issue
Feb 20, 2023
tags: chore What? - Change version Why? - New dev Issue #69
ArthurData
added a commit
that referenced
this issue
Feb 20, 2023
tags: doc What? - run `usethis::use_pipe()` Why? - missing tags issue #69
Closed
ArthurData
added a commit
that referenced
this issue
Feb 20, 2023
tags: chore What? - Change version Why? - New dev Issue #69
Merged
ArthurData
added a commit
that referenced
this issue
Feb 20, 2023
tags: doc What? - run `usethis::use_pipe()` Why? - missing tags issue #69
ArthurData
added a commit
that referenced
this issue
Mar 1, 2023
What? - check_dir has default param Why? - not write in user's home Issue Address CRAN comments #69
statnmap
added a commit
that referenced
this issue
Mar 3, 2023
tags: fix, doc Why? - URL need to be presented as reference in roxygen documentation What? - Use @references issue #69
statnmap
added a commit
that referenced
this issue
Mar 3, 2023
tags: feat, doc, test Why? - Need to create some packages to produce examples in function What? - create_example_pkg() can be used for exported examples issue #69
statnmap
added a commit
that referenced
this issue
Mar 3, 2023
tags: fix, feat Why? - CRAN require all directories created not to be inside current user workspace What? - Create a temp directory issue #69
CRAN_comments.md
|
2 tasks
statnmap
added a commit
that referenced
this issue
Jun 19, 2023
tags: feat, doc, test Styler does not like cat("cat('')"). Deal with multilines issue #69
statnmap
added a commit
that referenced
this issue
Jun 19, 2023
tags: doc - Explain each dontrun call to have an effect either on users workspace or running local check, which won't be possible during CRAN checks. issue #69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Validation criteria
pipe.Rd
:\value
#73 PR has been merged into main
check_as_cran
should not write in the user's home filespace#74
\dontrun{}
are replaced by\donttest{}
There is no remaining "data/iris.rda" at the root of the dev package (added during unit tests)
Context
If there are references describing the methods in your package, please
add these in the description field of your DESCRIPTION file in the form
authors (year) doi:...
authors (year) arXiv:...
authors (year, ISBN:...)
or if those are not available: https:...
with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
auto-linking. (If you want to add a title as well please put it in
quotes: "Title")
Please add \value to .Rd files regarding exported methods and explain
the functions results in the documentation. Please write about the
structure of the output (class) and also what the output means. (If a
function does not return a value, please document that too, e.g.
\value{No return value, called for side effects} or similar)
Missing Rd-tags:
pipe.Rd: \value
\dontrun{} should only be used if the example really cannot be executed
(e.g. because of missing additional software, missing API keys, ...) by
the user. That's why wrapping examples in \dontrun{} adds the comment
("# Not run:") as a warning for the user. Does not seem necessary.
Please replace \dontrun with \donttest.
Please unwrap the examples if they are executable in < 5 sec, or replace
dontrun{} with \donttest{}.
examples/vignettes/tests in the user's home filespace (including the
package directory and getwd()). This is not allowed by CRAN policies.
Please omit any default path in writing functions. In your
examples/vignettes/tests you can write to tempdir(). -> R/check_as_cran.R
The text was updated successfully, but these errors were encountered: