Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove desc as hard dep #765

Closed
ColinFay opened this issue Oct 15, 2021 · 2 comments · Fixed by #940
Closed

remove desc as hard dep #765

ColinFay opened this issue Oct 15, 2021 · 2 comments · Fixed by #940
Assignees
@ArthurData
Labels
Difficulty: novice effort: low hacktoberfest Issues for the hacktoberfest

Comments

@ColinFay
Copy link
Member

Just used in fill_desc.

Use same pattern as in add_dockerfile to check installation & version requirement.
@ArthurData
Copy link
Member

Thank you @ALanguillaume

ArthurData added a commit that referenced this issue Oct 28, 2021
@ArthurData
Remove {desc} as hard dep
db6f8af 
See #765
@ArthurData
Copy link
Member

{desc} is also used in check_name_consistency() > document_and_reload().
See #778

@ArthurData ArthurData linked a pull request Oct 31, 2021 that will close this issue
Issue 765 remove desc #778
Closed
@ColinFay ColinFay mentioned this issue Feb 25, 2022
Closed
@ArthurData ArthurData linked a pull request Oct 28, 2022 that will close this issue
feat: remove {desc} as hard dep #940
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArthurData ArthurData

Labels
Difficulty: novice effort: low hacktoberfest Issues for the hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove {desc} as hard dep ThinkR-open/golem
Issue 765 remove desc ThinkR-open/golem
2 participants
@ColinFay @ArthurData