Add test coverage #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwood
reviewed
Oct 28, 2020
.travis.yml
Outdated
| - "datagetter.py --help" # Verify it compiles and is installed | ||
| - "flake8" | ||
| - "isort --check-only --recursive ./" |
There was a problem hiding this comment.
@michaelwood was a suggestion of James. He said that it should be deleted. (I can't tag him here).
michaelwood
reviewed
Oct 28, 2020
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| [](https://travis-ci.com/ThreeSixtyGiving/datastore) | |||
|
|
|||
|
|
|||
| [](https://coveralls.io/github/ThreeSixtyGiving/Dashboard?branch=master) | |||
|
|
|||
There was a problem hiding this comment.
Just looking at the preview of the README, I think it might be better to have these all on one line as it is shunting the actual content down the page.
BibianaC
force-pushed
the
add_coverage
branch
2 times, most recently
from
6a037a5
to
3e5ecd5
Compare
BibianaC
force-pushed
the
add_coverage
branch
2 times, most recently
from
1ad6d71
to
575595a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to know what still needs to be tested, I have added coveralls.
90% tested!
I had to update requirements and by doing so, I had to fix
isortandblackerror messages.