-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage #61
Conversation
.travis.yml
Outdated
- "datagetter.py --help" # Verify it compiles and is installed | ||
- "flake8" | ||
- "isort --check-only --recursive ./" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove recursive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelwood was a suggestion of James. He said that it should be deleted. (I can't tag him here).
@@ -2,7 +2,8 @@ | |||
|
|||
[![Build Status](https://travis-ci.com/ThreeSixtyGiving/datastore.svg?branch=master)](https://travis-ci.com/ThreeSixtyGiving/datastore) | |||
|
|||
|
|||
[![Coverage Status](https://coveralls.io/repos/github/ThreeSixtyGiving/Dashboard/badge.svg?branch=master)](https://coveralls.io/github/ThreeSixtyGiving/Dashboard?branch=master) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just looking at the preview of the README, I think it might be better to have these all on one line as it is shunting the actual content down the page.
6a037a5
to
3e5ecd5
Compare
1ad6d71
to
575595a
Compare
In order to know what still needs to be tested, I have added coveralls.
90% tested!
I had to update requirements and by doing so, I had to fix
isort
andblack
error messages.