Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AWS region configurable #102

Closed
edgarrmondragon opened this issue Aug 5, 2024 · 0 comments · Fixed by #107
Closed

Make the AWS region configurable #102

edgarrmondragon opened this issue Aug 5, 2024 · 0 comments · Fixed by #107

Comments

@edgarrmondragon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently eu-west-1 is hard-coded in this target, it'd be nice (and necessary for some folks) to make it configurable.

class RedshiftSink(SQLSink):
"""Redshift target sink class."""
connector_class = RedshiftConnector
s3_client = boto3.client("s3", region_name="eu-west-1")

def get_credentials(self) -> tuple[str, str]:
"""Use boto3 to get temporary cluster credentials
Returns
-------
tuple[str, str]
username and password
"""
if self.config.get("enable_iam_authentication"):
client = boto3.client("redshift", region_name="eu-west-1")

Describe the solution you'd like

Add a new setting aws_region, which defaults to "eu-west-1".

Describe alternatives you've considered

Nothing so far.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant