Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow S3 bucket region to be specified or detected. #107

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Allow S3 bucket region to be specified or detected. #107

merged 1 commit into from
Aug 8, 2024

Conversation

techtangents
Copy link
Contributor

Fixes #102

Adds new config setting s3_region.

  • If specified, this region is given to the boto s3 client.
  • If not specified, no region is sent to the boto s3 client, and it'll use normal dependency resolution, e.g. the AWS_REGION environment variable

@techtangents techtangents requested a review from a team as a code owner August 8, 2024 11:11
tobiascadee
tobiascadee approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@tobiascadee tobiascadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition, thanks!

@tobiascadee tobiascadee merged commit 20aa16e into TicketSwap:main Aug 8, 2024
@edgarrmondragon edgarrmondragon mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiascadee tobiascadee tobiascadee approved these changes

Assignees
No one assigned
Labels
first approval ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the AWS region configurable
2 participants
@techtangents @tobiascadee