Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for lsat fixture and change challenge parsing #6

Closed
wants to merge 2 commits into from

Conversation

bucko13
Copy link
Collaborator

@bucko13 bucko13 commented Feb 19, 2021

Partly resolves #4. The other part seems related to the macaroon library being used. It either has a bug or has deliberately forked from the macaroon standard and will need to be replaced. I'm hoping for the former.

In the meantime, this fix still addresses the first error reported.

The issue was reported here

@bucko13
Copy link
Collaborator Author

bucko13 commented Feb 19, 2021

This adds a test for the macaroon from another library and since that's not working right now, that one test will fail.

@jacohend
Copy link
Collaborator

I see these travis failures:

tests/lsat.spec.ts(9,1): error TS6133: 'importMacaroon' is declared but its value is never read.
tests/lsat.spec.ts(9,32): error TS2307: Cannot find module 'macaroon' or its corresponding type declarations.

@bucko13
Copy link
Collaborator Author

bucko13 commented Feb 19, 2021

Ah thanks, forgot some cleanup. Unfortunately the tests will still fail since I added a test for the golang macaroon and that's not supported yet in the current macaroon lib. Debating whether or not to just put this fix in with the broken build and then either separately wait to upgrade the macaroon dep or go through the laborious process of ripping out the existing macaroon library...

@bucko13
Copy link
Collaborator Author

bucko13 commented May 10, 2021

closing in favor of #8

@bucko13 bucko13 closed this May 10, 2021
@bucko13 bucko13 deleted the parsing branch May 10, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Challenge Parsing fails with Base64 padding
2 participants