Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build for TileDB-Go #251

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jdblischak
Copy link

@jdblischak jdblischak commented Jan 19, 2023

Summary: This GitHub Actions workflow is scheduled to run every night. It builds TileDB-Go against the latest libtiledb

CC: @ihnorton

Workflow steps:

  1. Ubuntu: installs the nightly libtiledb binary that is uploaded to the tiledb conda channel every night. This is very quick
  2. macOS: If the Ubuntu build passes, then build the nightly libtiledb from source
  3. Issue: If either step 1 or 2 fails, open an Issue in the repository. If there is an existing open issue labeled "nightly-failure", it instead comments

Actions items before merging:

Notes:

  • The build against the latest libtiledb won't pass until either PR Remove deprecated usage of set query buffer functions #249 or PR Not use deprecated tiledb methods #250 is merged. I tested the pipeline against both of these PRs (by checking out their respective branches), and it passes
  • Unfortunately I couldn't get the conda infrastructure to cooperate on macOS. It would have made for a quicker build overall and a much simpler config file, but after trying a few different ideas to troubleshoot, I was stumped and didn't want to lose any more time in the effort
  • I had to disable the WebP functionality (-DTILEDB_WEBP=OFF) starting with libtiledb 2.13.1 (when it was first enabled by default). I confirmed that I didn't need this flag to build against libtiledb 2.13.0 (when the feature was first introduced, but disabled by default)
  • The file install_tiledb_source_macos.sh is a copy of the one in .github/scripts with the following modifications:
    • Checkout "dev" instead of a specific tag
    • Only clone the latest commit
    • Disable WebP
  • An issue will only be automatically opened for scheduled jobs in the main repository. This will prevent Issues from being opened in forks or during pull requests (but still allow the other steps to run to test modifications to the nightly build)
  • I attempted to follow the style and formatting of the existing GitHub Actions workflow tiledb-go.yml

@jdblischak
Copy link
Author

I've pushed multiple commits to aid reviewing. But since they are all related to creating a nightly build, please squash them when it's ready to merge (I can also squash them manually post-review if that's preferred)

@jdblischak
Copy link
Author

Now that #249 was merged, the nightly builds in this PR should pass. In other words, it's safe to merge once it's passed review and the remaining action items listed above have been completed

@jdblischak
Copy link
Author

As expected, after rebasing, the nightly workflows are now successfully building on my fork (build logs)

@jdblischak
Copy link
Author

Update. The nightly build passed 3 days ago (Tues, 24th) with the nightly libtiledb version 2.15.0.2023_01_23, but today it is failing with version 2.15.0.2023_01_26. There haven't been any changes to TileDB-Go, so I assume the new problem was introduced by recent commits to TileDB:

TileDB-Inc/TileDB@5d51c9e...fd52600

Note that I grabbed the exact commits from the nightly build logs because there were commits merged around the time the nightly builds were started.

@jdblischak
Copy link
Author

I restarted the previously failed nightly job on my fork, and it is still failing, now with libtiledb 2.15.0.2023_01_29

@jdblischak
Copy link
Author

Nightly build still failing with 2.15.0.2023_01_31 (thanks @ihnorton for triggering the re-run)

https://github.com/TileDB-Inc/TileDB-Go/actions/runs/4026004705/jobs/6990363588#step:3:299

@jdblischak
Copy link
Author

Since the nightly build for TileDB-MariaDB just started passing last night (TileDB-Inc/TileDB-MariaDB#216 (comment)), I restarted the TileDB-Go nightly job on my fork. Unfortunately it is still failing with libtiledb 2.15.0.2023_02_07

@jdblischak
Copy link
Author

I rebased my PR to include the recently merged #254. The nightly build is still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants