Skip to content

feat: Add parse methods to all score implementations #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Christopher-Chianelli
Copy link
Collaborator

No description provided.

Copy link

@triceo
Copy link
Contributor

triceo commented Jun 17, 2024

Is there a reason why we're adding this?

@Christopher-Chianelli
Copy link
Collaborator Author

Is there a reason why we're adding this?

Cause Score classes in Java has parse and it is extremely convenient for deserialization from score string?

@triceo
Copy link
Contributor

triceo commented Jun 17, 2024

Any chance we could call those Java solver methods under the hood, instead of duplicating the code?

@Christopher-Chianelli
Copy link
Collaborator Author

Any chance we could call those Java solver methods under the hood, instead of duplicating the code?

No; these are pure Python objects so they can be handled by Python libraries

@Christopher-Chianelli Christopher-Chianelli merged commit 3942327 into TimefoldAI:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants