Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to install generated ilbc_export.h #28

Closed
marillat opened this issue Dec 18, 2020 · 0 comments · Fixed by #29
Closed

Unable to install generated ilbc_export.h #28

marillat opened this issue Dec 18, 2020 · 0 comments · Fixed by #29
Milestone
Release 3.0.2

Comments

@marillat
Copy link

Hi,
Debian unstable amd64. The build fail with

-- Installing: /src/libilbc-3.0.1/debian/tmp/usr/lib/x86_64-linux-gnu/pkgconfig/libilbc.pc
-- Installing: /src/libilbc-3.0.1/debian/tmp/usr/include/ilbc.h
CMake Error at cmake_install.cmake:50 (file):
  file INSTALL cannot find "/src/libilbc-3.0.1/ilbc_export.h": No such file
  or directory.
FAILED: CMakeFiles/install.util

This simple patch fix this issue

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -323,7 +323,9 @@ add_custom_target(ilbc_test-sample
 
 install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libilbc.pc
         DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig)
-install(FILES ilbc.h ilbc_export.h
+install(FILES ilbc.h
+        DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
+install(FILES ${CMAKE_CURRENT_BINARY_DIR}/ilbc_export.h
         DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
 install(FILES CONTRIBUTING.md NEWS.md README.md
         DESTINATION ${CMAKE_INSTALL_DOCDIR})
@dbermond dbermond mentioned this issue Dec 18, 2020
Merged
dbermond added a commit to dbermond/libilbc that referenced this issue Dec 18, 2020
@dbermond
Fix install when using a separated build directory
973d43f 
This fixes the following error at 'make install' time when
using a separated build directory (out-of-tree build):

CMake Error at cmake_install.cmake:50 (file):
  file INSTALL cannot find "/build/libilbc/src/libilbc/ilbc_export.h": No
  such file or directory.
make: *** [Makefile:105: install] Error 1
make: Leaving directory '/build/libilbc/src/build'

How to reproduce:

$ git clone --recursive https://github.com/TimothyGu/libilbc.git
$ cmake -B build -S libilbc
$ make -C build
$ make -C build install

Fixes TimothyGu#28
TimothyGu pushed a commit that referenced this issue Dec 18, 2020
@dbermond
Fix install when using a separated build directory (#29)
1364112 
This fixes the following error at 'make install' time when
using a separated build directory (out-of-tree build):

CMake Error at cmake_install.cmake:50 (file):
  file INSTALL cannot find "/build/libilbc/src/libilbc/ilbc_export.h": No
  such file or directory.
make: *** [Makefile:105: install] Error 1
make: Leaving directory '/build/libilbc/src/build'

How to reproduce:

$ git clone --recursive https://github.com/TimothyGu/libilbc.git
$ cmake -B build -S libilbc
$ make -C build
$ make -C build install

Fixes #28
@TimothyGu TimothyGu mentioned this issue Dec 18, 2020
Merged
@TimothyGu TimothyGu added this to the Release 3.0.2 milestone Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.0.2
Development

Successfully merging a pull request may close this issue.

Fix install when using a separated build directory dbermond/libilbc
2 participants
@TimothyGu @marillat