Allow verbose flag to be passed as args #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa93hws
commented
Apr 9, 2022
| -V, --version Print version information and exit. | ||
| -w, --workspacePath=<workspacePath> | ||
| Path to Bazel workspace directory. | ||
| --displayElapsedTime This flag controls whether to print out elapsed time |
There was a problem hiding this comment.
It's not released yet, so it would be safe to remove this flag.
fa93hws
commented
Apr 9, 2022
| public String[] getVersion() throws Exception { | ||
| return new String[] { | ||
| "3.2.2" | ||
| "3.4.0" |
There was a problem hiding this comment.
Latest release is 3.4.0 https://github.com/Tinder/bazel-diff/releases/tag/3.4.0
tinder-maxwellelliott
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#110 (comment) reminds me that
verbosecan only be set at build time by settingcompilation_modetodbg. User should get verbose message printed by passing a flag at runtime.