Skip to content

fix: Duration Reporting #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: Duration Reporting #172

merged 1 commit into from
Mar 21, 2023

Conversation

nikhilbirmiwal
Copy link
Contributor

Reusing the same Calendar instance would report all durations as 0 milliseconds. Create a new Calendar instance for the start and end timestamps.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nikhilbirmiwal nikhilbirmiwal changed the title fix: Fix Duration Reporting fix: Duration Reporting Mar 13, 2023
tinder-maxwellelliott
tinder-maxwellelliott approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you approve the CLA, I'll merge this! Thanks!

@nikhilbirmiwal
Copy link
Contributor Author

Done. Thanks for the awesome tool!

@tinder-maxwellelliott tinder-maxwellelliott merged commit 7f08714 into Tinder:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinder-maxwellelliott tinder-maxwellelliott tinder-maxwellelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikhilbirmiwal @CLAassistant @tinder-maxwellelliott