Fix computing external repo fine-grained hashes #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation ignores any change of source files in external repos. That implementation works for maven_install because maven_install does not download any jars into that particular repo. But it does not work for cases when the external repo comes with sources/jars in itself. We have such use cases internally in Pinterest though I am not aware of any such use cases in common open source world.
|
Hi @tinder-maxwellelliott , can you take a look when you have time? Thanks! |
|
Gentle ping 😄 |
Thanks again |
|
Could you create another release? Thank you!! |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation ignores any change of source files in external repos. That implementation works for maven_install because maven_install does not download any jars into that particular repo. But it does not work for cases when the external repo comes with sources/jars in itself.
We have such use cases internally in Pinterest though I am not aware of any such use cases in common open source world. I have tested this implementation with our internal repo and it seems to work as expected. Interestingly, the difference of introduced in this PR is also sort of captured by the e2e test.