Skip to content

Conversation

tinder-maxwellelliott
Copy link
Collaborator

Related Different workspaces produce different hashes #180

Related Different workspaces produce different hashes #180
Copy link

@erikkerber erikkerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏼 🙇🏼

@tinder-maxwellelliott tinder-maxwellelliott changed the title WIP: Ignore location attribute Allows for controlling with attributes are ignored during rule hashing Jun 8, 2023
@tinder-maxwellelliott tinder-maxwellelliott marked this pull request as ready for review June 8, 2023 19:07
@erikkerber
Copy link

@tinder-maxwellelliott Extreme apologies, my last test was bad because I didn't change the --workspacePath, I just ran from both repos locations 🙈

I owe you some debugging to see what might be up with that approach.

@tinder-maxwellelliott tinder-maxwellelliott merged commit 6752eff into master Jun 9, 2023
@tinder-maxwellelliott tinder-maxwellelliott deleted the maxwelle/ignore-location-attribute-when-computing-hashes branch June 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants