Skip to content

Don't store file contents to lazy-calculate digests #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2021
Merged

Don't store file contents to lazy-calculate digests #98

merged 1 commit into from
Nov 17, 2021

Conversation

fahhem
Copy link
Contributor

@fahhem fahhem commented Nov 17, 2021

Closes #97

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tinder-maxwellelliott
tinder-maxwellelliott approved these changes Nov 17, 2021
View reviewed changes
Copy link
Collaborator

@tinder-maxwellelliott tinder-maxwellelliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @fahhem !!!

@tinder-maxwellelliott tinder-maxwellelliott merged commit 43d0025 into Tinder:master Nov 17, 2021
@fahhem fahhem deleted the fahhem/memdecrease branch November 17, 2021 02:08
@fahhem
Copy link
Contributor Author

fahhem commented Nov 17, 2021

That was quick! How hard is it to get another release?

@tinder-maxwellelliott
Copy link
Collaborator

Should be up in around 10 mins or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinder-maxwellelliott tinder-maxwellelliott tinder-maxwellelliott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory "leak": Whole source directory is loaded into memory to lazy-generate digests
3 participants
@fahhem @CLAassistant @tinder-maxwellelliott