Addresses #5 #18
Addresses #5 #18
Conversation
| public Task AddJob(JobDb job) | ||
| { | ||
| var wrappedJob = JobInMemoryWrapper.CreateJobInMemoryWrapper(job); | ||
| _jobsStorage.AddOrUpdate(job.JobId, wrappedJob, (_, __) => wrappedJob); |
There was a problem hiding this comment.
go style? Maybe use (x,y) better?
There was a problem hiding this comment.
I dont see much diference TBH, but if you insist - sure
| public Task<string> GetCronForRecurrentJob(string jobKey) | ||
| { | ||
| if (!_recurrentJobSettingsStorage.TryGetValue(jobKey, out var settings)) | ||
| throw new Exception("Не найдены настройки для рекуррентного джоба"); |
There was a problem hiding this comment.
Guess i'll fix it in MongoRepository too then
| private static readonly Lazy<InMemoryRepository> | ||
| Repository = new Lazy<InMemoryRepository>(() => new InMemoryRepository()); | ||
|
|
||
| public static IJobRepository Create() => Repository.Value; |
There was a problem hiding this comment.
The interface in the factory is not good because of the method Create every time return one repository.
There was a problem hiding this comment.
True this.
I guess then we should just remove the factory - new InMemoryRepository does the job. What say you?
| using System.Threading.Tasks; | ||
| using Horarium.Repository; | ||
|
|
||
| namespace Horarium.InMemory |
There was a problem hiding this comment.
This class is perfect for unit testing, sorry 😭
There was a problem hiding this comment.
:pepehands:
Some things... you know, they just must be done - i'll cover it with tests at some point - again, when i'll have the time
|
@itrofimow I will close and open the pull request for test auto build. |
#5