Skip to content

Performant inmemory #22

Merged
merged 12 commits into from
Sep 3, 2019
Merged

Performant inmemory #22

merged 12 commits into from
Sep 3, 2019

Conversation

itrofimow
Copy link
Contributor

This is more performant (well i hope so) version of #18

@Bobreshovr Bobreshovr self-requested a review June 13, 2019 19:29
@Bobreshovr
Copy link
Contributor

Provocation!!! 😄 What about liteDB?

@itrofimow
Copy link
Contributor Author

itrofimow commented Jun 13, 2019

Didn't have a close look at LiteDb, but i am not that sure it's any better - i mean, yes,

  • it can persist the DB in a file, but is it really usable tho? - if someone needs to persist their jobsDB, then neither inMemory nor files aren't a good solution, point stands
  • Indexes out of the box, covered with tests.. well, sure. But i believe that inMemory repo should not only be super easy to setup, but also (and not less important IMO) be as fast as possible. Are you sure LiteDb is more performant than this approach? You never know until you run a good load test :)

@Bounz
Copy link
Contributor

Bounz commented Jun 17, 2019

Guys, don't you want to use https://github.com/dotnet/BenchmarkDotNet to measure performance improvements/deteriorations during the work on im-memory store?

@Bobreshovr Bobreshovr changed the base branch from master to feature/5 September 3, 2019 13:59
@Bobreshovr Bobreshovr merged commit 9ac816d into Tinkoff:feature/5 Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants