Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac fixes #86

Closed
wants to merge 11 commits into from
Closed

Mac fixes #86

wants to merge 11 commits into from

Conversation

Xaec6
Copy link

@Xaec6 Xaec6 commented Jun 4, 2017

If you ever get a mac, my other branch has all the xcode project files needed to debug in xcode.

@Tinob
Copy link
Owner

Tinob commented Jun 8, 2017

just commited to master a fix based in your code, thereal reason for the issue was that mac osx drivers does not support binding layout, so texture indexes where all wrong, so with the new updated that should be fixed. please test it and let me know.

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

There are many graphical glitches with 3d rendering in this fix. Several textures not drawing. In Luigi's Mansion only the GUI is drawn. This didn't happen with the original fixes. It seems to be the issue I had when trying to just set FIRST_INPUT_TEXTURE_UNIT to 0. Also, it's lagging a lot.

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

thanks for report back, will take test that specific game then to debug the problem

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

If I undo the changes in texture cache it seems to work fine. Also, ignore the comment about slowness that was an error on my part.

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

Everything seems to be running perfectly now

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

can you send me exactly what changes did you revert?

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

Changes around line 508 and changes around 563 in TextureCache

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

can you make a quick test, instead of reverting that can you change the functions BindNearestSampler and BindLinearSampler adding this lines at the top

if (stage < 8)
{
auto& active_sampler = m_active_samplers[stage];
active_sampler.first = SamplerCache::Params();
active_sampler.second = SamplerCache::Value();
}

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

Doesn't work. I can get it to work with just reverting changes around line 508

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

an you also reverted the changes in TextureConverter?

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

No, only reverts now are around line 508

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

just pushed some change scan you test that the issues are fixed?

@Xaec6
Copy link
Author

Xaec6 commented Jun 9, 2017

Works perfectly.

@Tinob
Copy link
Owner

Tinob commented Jun 9, 2017

nice :)

@Xaec6 Xaec6 closed this Jun 9, 2017
@Xaec6 Xaec6 deleted the Mac-noxcodeproj branch June 9, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants