-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac fixes #86
Mac fixes #86
Conversation
just commited to master a fix based in your code, thereal reason for the issue was that mac osx drivers does not support binding layout, so texture indexes where all wrong, so with the new updated that should be fixed. please test it and let me know. |
There are many graphical glitches with 3d rendering in this fix. Several textures not drawing. In Luigi's Mansion only the GUI is drawn. This didn't happen with the original fixes. It seems to be the issue I had when trying to just set FIRST_INPUT_TEXTURE_UNIT to 0. Also, it's lagging a lot. |
thanks for report back, will take test that specific game then to debug the problem |
If I undo the changes in texture cache it seems to work fine. Also, ignore the comment about slowness that was an error on my part. |
Everything seems to be running perfectly now |
can you send me exactly what changes did you revert? |
Changes around line 508 and changes around 563 in TextureCache |
can you make a quick test, instead of reverting that can you change the functions BindNearestSampler and BindLinearSampler adding this lines at the top if (stage < 8) |
Doesn't work. I can get it to work with just reverting changes around line 508 |
an you also reverted the changes in TextureConverter? |
No, only reverts now are around line 508 |
just pushed some change scan you test that the issues are fixed? |
Works perfectly. |
nice :) |
If you ever get a mac, my other branch has all the xcode project files needed to debug in xcode.