feat!: include sqlmesh in version check #2125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eakmanrq
commented
Feb 14, 2024
tests/core/test_state_sync.py
Outdated
There was a problem hiding this comment.
This looks like a typo in this test. error was defined but never used. Updated to check for it similar to what is done below.
eakmanrq
force-pushed
the
eakmanrq/add_sqlmesh_version_check
branch
from
f63ef8d to
4ed192a
Compare
tobymao
reviewed
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we considered SQLMesh versions "compatible", or that they could be run together, if they shared a common sqlglot minor version and were on the same migration release. Sometimes though we introduce incompatibility that doesn't require a migration and we represent this with a minor version bump. Therefore this change now considers SQLMesh's minor version too when deciding if releases are compatible.